Port Plots.jl recipe features to Makie recipe for AbstractTimeseriesSolution #1064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olution - Add support for discrete variable plotting with stepped lines - Add plottable_indices function for proper default index selection - Add plot_analytic support to show analytical solutions with dashed lines - Add proper empty data handling - Use SciMLBase.isdenseplot for dense/sparse output determination - Separate continuous and discrete variables based on timeseries indexes This brings the Makie recipe to feature parity with the Plots.jl recipe, enabling proper visualization of mixed continuous/discrete solutions and analytical comparisons. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR ports missing functionality from the Plots.jl recipe to the Makie recipe for
AbstractTimeseriesSolution, bringing them to feature parity.Changes
plot_analyticsupport to show analytical solutions alongside numerical ones (with dashed lines)plottable_indicesfunction for proper default index selectionSciMLBase.isdenseplotfor correct dense vs sparse determinationImplementation Details
The main changes are in
ext/SciMLBaseMakieExt.jl:plot_analytic=true) are shown with dashed linesplottable_indicesAll features are implemented using Makie's PlotSpec API within the constraints of
convert_arguments.Testing
This needs testing with:
🤖 Generated with Claude Code